Dev Log: First PR Into Ecency
It might seem like a tiny thing, but I feel it to be a sort of milestone for myself. Today I submitted a PR to @ecency. This pull request is the first step toward integrating a simple video system for all of Hive's front ends.
It's been on my plate, on my to-do list, for a while. Some weeks ago now, @good-karma invited me as a contributor, and I made it a point to download the repo and learn enough about it to have a valid attack vector. Yet I'm not going to lie and say it's not intimidating to submit code.
So what am I attempting to do with this PR? I hear you asking. Well, the idea is simple to say, not so simple to do: to move away from the legacy video system we have for @threespeak for good. We still have the mobile app using the legacy path, but after that we would be done.
Also, this simplified upload system—the embed uploads, as I call them—should be easy enough to implement for any front end that wants to have @threespeak videos. It's loosely coupled, I guess, and thus flexible.
On the other hand, today I also submitted a big PR into our ride-sharing app, the one I talked about on the last @mantequilla-soft hangout. Implementing communities, verifications, and generally adding a layer of safety to the darn thing. As of right now, that PR—that working feature—has over 50 change requests, courtesy of my brother. When I say he's a rough code reviewer, I mean it.
At any rate, a productive day. Although it started with shenanigans. Shenanigans, mind you, that prevented me from assisting with the important call on DHF budgets that happened today.
And on that note, I think I'm going to call it a night while I listen to the playback.
—MenO
Leave Dev Log: First PR Into Ecency to:
Read more #hive posts
Best Posts From MenO
We have not curated any of meno's posts yet. But you can encourage our curation team to review posts by visiting them regularly and by referring other readers. Because we give priority to frequently read content.